-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #5729 Refactor Cloudflare implementation #5884
Conversation
I found one case where the transient was incorrectly set early, I pushed a commit to fix this |
@Tabrisrp We still have a problem on newlabs as follows now
|
What are the steps for this case? |
@CrochetFeve0251 Thanks for the update. The latest scenario is fixed, however, can see the following issues (working fine on trunk) |
…nto enhancement/update-cloudflare
@CrochetFeve0251 Thank you for the update. The scenario where saving the correct credentials after a fresh installation was causing an error is fixed. 🎉 However, both of the scenarios described by Mai in the previous comment are still there. For the second one, the following notice is displayed: Cloudflare cache level error: Incorrect Cloudflare Zone ID. Read the [documentation](https://docs.wp-rocket.me/article/18-using-wp-rocket-with-cloudflare/?utm_source=wp_plugin&utm_medium=wp_rocket#add-on) for further guidance.
Cloudflare minification error: Incorrect Cloudflare Zone ID. Read the [documentation](https://docs.wp-rocket.me/article/18-using-wp-rocket-with-cloudflare/?utm_source=wp_plugin&utm_medium=wp_rocket#add-on) for further guidance.
Cloudflare rocket loader error: Incorrect Cloudflare Zone ID. Read the [documentation](https://docs.wp-rocket.me/article/18-using-wp-rocket-with-cloudflare/?utm_source=wp_plugin&utm_medium=wp_rocket#add-on) for further guidance.
Cloudflare browser cache error: Incorrect Cloudflare Zone ID. Read the [documentation](https://docs.wp-rocket.me/article/18-using-wp-rocket-with-cloudflare/?utm_source=wp_plugin&utm_medium=wp_rocket#add-on) for further guidance. Can you please look into these? 🙏 |
I can see the following edge case, which is not blocking. The same error as @vmanthos shared is displayed. Steps to reproduce:
|
@piotrbak I checked the PR with the latest commits, and I can't reproduce scenario 2 but I can consistently do that for scenario 1. Screencast in Slack Convo (non-public link). |
Co-authored-by: COQUARD Cyrille <[email protected]>
Description
Refactor Cloudflare implementation
Fixes #5729
Type of change
Checklist: